precompile: Remove extra checks #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
force-pushed
the
feat/drop-axelar-precompile-checks
branch
from
16eb0b0 to
27adf18
Compare
mustermeiszer
commented
Sep 9, 2023
pallets/liquidity-pools-gateway/axelar-gateway-precompile/src/cargo_expand.rs
Outdated
Show resolved
Hide resolved
cdamian
force-pushed
the
feat/drop-axelar-precompile-checks
branch
2 times, most recently
from
bb617b8 to
21717c3
Compare
cdamian
reviewed
Sep 10, 2023
cdamian
requested review from
NunoAlexandre,
wischli and
lemunozm
as code owners
cdamian
force-pushed
the
feat/drop-axelar-precompile-checks
branch
from
55551ec to
31aa21e
Compare
mustermeiszer
commented
Sep 11, 2023
cdamian
force-pushed
the
feat/drop-axelar-precompile-checks
branch
2 times, most recently
from
5c0da30 to
d0329d2
Compare
|
I can not approve as I created the PR. But looks all good to me! |
cdamian
approved these changes
Sep 12, 2023
NunoAlexandre
approved these changes
Sep 12, 2023
4 tasks
cdamian
force-pushed
the
feat/drop-axelar-precompile-checks
branch
from
d0329d2 to
a46c234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dropping any EVM storage related validation that we have in place and treat this precompile as a simple forwarded for gateway messages.
Checklist: